[Openmp-commits] [PATCH] D95467: [libomptarget][cuda] Only run tests when sure there is cuda available

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.
Herald added a subscriber: sstefan1.


================
Comment at: openmp/libomptarget/plugins/cuda/CMakeLists.txt:26
 include_directories(${LIBOMPTARGET_DEP_LIBELF_INCLUDE_DIRS})
 
+set(LIBOMPTARGET_DLOPEN_LIBCUDA OFF)
----------------
The use of 'option' before actually set LIBOMPTARGET_DLOPEN_LIBCUDA to ON, despite cmake's documentation. This auxiliary variable workaround is copied from other uses of option() in this library.

Also, 'AND' doesn't work in the context of set. `set(VAR ${A} AND ${B})` writes the list containing A, AND, B to VAR. That list is then considered 'true' in conditional statements, even when the list is `;FALSE;AND;FALSE;`. Therefore set and mutate a variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95467/new/

https://reviews.llvm.org/D95467