[Openmp-commits] [PATCH] D95282: [OpenMP] Add source location information to the libomptarget profile

Tue Jan 26 05:09:22 PST 2021

grokos added inline comments.

================
Comment at: openmp/libomptarget/src/omptarget.cpp:217
                      TargetDataFuncPtrTy target_data_function) {
+  TIMESCOPE_WITH_IDENT(loc);
   DP("Calling the mapper function " DPxMOD "\n", DPxPTR(arg_mapper));
----------------
I see some inconsistency here. `targetDataMapper` is an internal libomptarget function (not an API function) and yet it is getting profiled. Same for `targetDataContiguous` and `targetDataNonContiguous`. The other 3 internal data-related functions `targetDataBegin`, `targetDataEnd` and `targetDataUpdate` are not. Is this intentional?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95282/new/

https://reviews.llvm.org/D95282