[Openmp-commits] [PATCH] D95412: [libomptarget][cuda] Gracefully handle missing cuda library

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.
Herald added a subscriber: sstefan1.

Noticed when running offloading on a system with no cuda available. Failing to load cuda from the global constructor didn't matter, but the segv on calling cuGetErrorString did.

An existing hazard, this plugin doesn't record whether the constructor initialisation succeeded (aside from debug messages). If it failed, but there are nvptx offloading images present, I think libomptarget will call back into this library despite the constructor failing, and I'm not sure that will reliably report an error instead of crash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95412/new/

https://reviews.llvm.org/D95412