[Openmp-commits] [PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/common/allocator.h:16
+
+// Follows the pattern in interface.h
+// Clang sema checks this type carefully, needs to closely match that from omp.h
----------------
If we guard this with #ifdef _OPENMP, and we change amdgcn/src/target_impl.h from

`#define SHARED __attribute__((shared))`
to
`#define SHARED(NAME) __attribute__((shared)) NAME`
`#define EXTERN_SHARED(NAME) __attribute__((shared)) NAME`

then there's a credible chance the downstream amdgpu hip build will continue working


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94745/new/

https://reviews.llvm.org/D94745