[Openmp-commits] [PATCH] D94855: [OpenMP] Add time profiling support in libomp

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

I see two issues in this patch. `LIBOMPTARGET_LLVM_INCLUDE_DIRS` is not included when building `libomp.so` therefore the header will not be found (in my case). Another probably bigger one is D95371 <https://reviews.llvm.org/D95371>. From my observation, code in `runtime` is very conservative in terms of using C++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94855/new/

https://reviews.llvm.org/D94855