[Openmp-commits] [PATCH] D95318: [OpenMP][NFC] Format all files in OpenMP

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

There is a 'correct' version of clang-format to use. It's whatever phab runs as part of the auto-checking machinery. Hopefully that's clang-format from trunk, as that one is always available on disk, but it might also be the one from the last release.

Aside from clang-format, changes to this library are plagued by clang-tidy warnings. Some are fixable - our_function can become ourFunction. Some are not, such as warnings on uint32_t. Some might be - errors on unrecognised intrinsics because it assumes x64 (or at least, doesn't assume amdgcn/nvptx), or warnings about <gelf.h> not being found.

I'm in favour of running (preferably the above version) of clang-format across everything, ideally at a moment when there aren't a lot of large open reviews. Arcanist barks at me when I forget to clang-format the change, so perhaps that will suffice to avoid needing this again in a year or so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95318/new/

https://reviews.llvm.org/D95318