[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for hidden helper task in RTL

Sun Jan 24 16:32:32 PST 2021

tianshilei1992 added a comment.

In D77609#2518640 <https://reviews.llvm.org/D77609#2518640>, @JonChesterfield wrote:

>> The only potential problem is printf in the target region doesn't work at all, which I believe has nothing to do with this patch.
>
> Do you see the print statements within the region without this patch applied? On sm_50, I see all the print output on trunk and the ones inside target missing with this patch.
>
> I suspect there is a race condition in the library that this patch has exposed.
>
> Did you run the test under valgrind? The fair scheduler setting does a reasonable job of perturbing thread order, though I suppose one should use an actual race detector instead.

I tested the latest version of this patch, and it can print out all information. Can you give it a shot on your side with AMD GPUs?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609