[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for hidden helper task in RTL

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Jan 24 16:16:24 PST 2021


JonChesterfield added a comment.

> The only potential problem is printf in the target region doesn't work at all, which I believe has nothing to do with this patch.

Do you see the print statements within the region without this patch applied? On sm_50, I see all the print output on trunk and the ones inside target missing with this patch.

I suspect there is a race condition in the library that this patch has exposed.

Did you run the test under valgrind? The fair scheduler setting does a reasonable job of perturbing thread order, though I suppose one should use an actual race detector instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609



More information about the Openmp-commits mailing list