[Openmp-commits] [PATCH] D95298: [OpenMP][libomptarget][WIP] Refined the file structure of `deviceRTLs`

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Jan 23 15:34:40 PST 2021


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu:36
 
+DEVICE uint32_t __kmpc_impl_ffs(uint32_t x) { return __builtin_ffs(x); }
+
----------------
Moving these into the implementation seems reasonable. We could also find a header other than target_impl.h to put them in, and drop them from the target specific part entirely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95298/new/

https://reviews.llvm.org/D95298



More information about the Openmp-commits mailing list