[Openmp-commits] [PATCH] D95003: [OpenMP] libomp: implement OpenMP 5.1 nteams-var and teams-thread-limit-var ICVs

[Hansang Bae via Phabricator via Openmp-commits]

hbae added a comment.

The scope of //nteams-var// and //teams-thread-limit-var// is device, so I believe proper handling in plugin should be using extended variable name such as OMP_NUM_TEAMS_DEV[_<device>] as described in OpenMP 5.1 page 75.
I think it is best to leave this up to contributors to each plugins.

  1 Each ICV that does not have global scope (see Table 2.3) has a set of device-specific environment
  2 variables that extend the variables defined in Table 2.1 with the following syntax:
  3 <ENVIRONMENT VARIABLE>_DEV[_<device>]
  4 where <ENVIRONMENT VARIABLE> is one of the variables from Table 2.1 and <device> is the
  5 device number as specified in the device clause (see Section 2.14).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95003/new/

https://reviews.llvm.org/D95003