[Openmp-commits] [PATCH] D95282: [OpenMP] Add source location information to the libomptarget profile

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/include/SourceInfo.h:77
   std::string removePath(const std::string &path) const {
     std::size_t pos = (OS_WINDOWS) ? path.rfind('\\') : path.rfind('/');
     return path.substr(pos + 1);
----------------
jhuber6 wrote:
> tianshilei1992 wrote:
> > jhuber6 wrote:
> > > tianshilei1992 wrote:
> > > > This comment might not relate to this patch. I'm just wondering, this header file should be a totally new file. Why the code is not using LLVM style?
> > > Is there anything wrong with it besides the variable names? I just forgot that LLVM uses Pascal case for its variables when I wrote it.
> > Yeah, those variable and type names.
> The `ident_t` type name is just to be compatible with the rest of libomp and I made `map_var_info_t` as an alias to mimic that. I could fix the variable names real quick.
That would be perfect!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95282/new/

https://reviews.llvm.org/D95282