[Openmp-commits] [PATCH] D95282: [OpenMP] Add source location information to the libomptarget profile

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: openmp/libomptarget/include/SourceInfo.h:77
   std::string removePath(const std::string &path) const {
     std::size_t pos = (OS_WINDOWS) ? path.rfind('\\') : path.rfind('/');
     return path.substr(pos + 1);
----------------
This comment might not relate to this patch. I'm just wondering, this header file should be a totally new file. Why the code is not using LLVM style?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95282/new/

https://reviews.llvm.org/D95282