[Openmp-commits] [PATCH] D93055: [OpenMP] Add time profiling for libomptarget

Fri Jan 22 15:57:42 PST 2021

vzakhari added a comment.

In D93055#2516823 <https://reviews.llvm.org/D93055#2516823>, @kkwli0 wrote:

> In D93055#2516351 <https://reviews.llvm.org/D93055#2516351>, @vzakhari wrote:
>
>> FYI, `libomptarget` LIT tests fail with profiling enabled in shared-libs builds, because `libLLVMSupport.so.12git` dependency cannot be resolved.  Apparently, `LD_LIBRARY_PATH` is only set to `<build>/llvm/projects/openmp/libomptarget`, which obviously does not contain the support library.
>
> @vzakhari Is it an out-of-tree build?  If it is, you need to set `LIBOMPTARGET_OPENMP_HEADER_FOLDER` and `DLIBOMPTARGET_OPENMP_HOST_RTL_FOLDER` (https://github.com/llvm/llvm-project/tree/main/openmp#id11).

No, it is an in-tree build.  I see `libomptarget`'s output location (`LIBOMPTARGET_LIBRARY_DIR`) does not align well with the default `rpath` setting done inside `add_llvm_library`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93055/new/

https://reviews.llvm.org/D93055