[Openmp-commits] [PATCH] D95155: [libomptarget] Build cuda plugin without cuda installed locally

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

One nit wrt. _v2 not _v2, otherwise LGTM.



================
Comment at: openmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.h:102
+CUresult cuMemcpyPeerAsync(CUdeviceptr, CUcontext, CUdeviceptr, CUcontext,
+                           size_t, CUstream);
+
----------------
JonChesterfield wrote:
> jdoerfert wrote:
> > @tra suggested to name the declarations as they are actually named, e.g., _v2. I don't have strong feelings either way, this is kinda messy and weird no matter how we name them.
> Don't mind either way, will rebase this if RTL.cpp is changed to use the v2 functions. Change seems orthogonal.
I think the idea was to define it with the right name, thus _v2, but use it with the fake one, so not _v2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95155/new/

https://reviews.llvm.org/D95155