[Openmp-commits] [PATCH] D95170: [OpenMP] Fix misleading warning for OMP_PLACES

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

In D95170#2515674 <https://reviews.llvm.org/D95170#2515674>, @jlpeyton wrote:

> In D95170#2513762 <https://reviews.llvm.org/D95170#2513762>, @protze.joachim wrote:
>
>> In my quick test, `env KMP_SETTINGS=1 OMP_PROC_BIND=spread ./a.out` reports `OMP_PLACES='cores'`. I could not find the code path that sets places to cores in this case, but I think it would be more consistent to have consistent setting in the unset and the invalid case.
>>
>> Is there a reason to choose threads?
>
> Internally here at Intel we did have it at threads at one point, then somehow it got changed, and this was just to change it back to threads. It would be more consistent to have it default to OMP_PLACES=cores because of the case you mentioned and KMP_AFFINITY defaults to core granularity as well.  @AndreyChurbanov , are you ok with keeping it as OMP_PLACES="cores" and just changing the warning message to cores instead?

Fine with me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95170/new/

https://reviews.llvm.org/D95170