[Openmp-commits] [PATCH] D95155: [libomptarget] Build cuda plugin without cuda installed locally

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jan 22 03:12:24 PST 2021


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.h:102
+CUresult cuMemcpyPeerAsync(CUdeviceptr, CUcontext, CUdeviceptr, CUcontext,
+                           size_t, CUstream);
+
----------------
jdoerfert wrote:
> @tra suggested to name the declarations as they are actually named, e.g., _v2. I don't have strong feelings either way, this is kinda messy and weird no matter how we name them.
Don't mind either way, will rebase this if RTL.cpp is changed to use the v2 functions. Change seems orthogonal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95155/new/

https://reviews.llvm.org/D95155



More information about the Openmp-commits mailing list