[Openmp-commits] [PATCH] D95155: [libomptarget] WIP build plugin without cuda.h

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.cpp:86
+  // TODO: Probably need a lock / call_once around the check
+  if (!checkForCUDA()) {
+    return CUDA_ERROR_INVALID_VALUE;
----------------
cuInit is called by deviceRTL's global constructor, so might be fine as-is. I'm not sure we're destroying the cuda dynamic library at present


================
Comment at: openmp/libomptarget/plugins/cuda/dynamic_cuda/cuda.h:13
+
+#ifndef CUDA_H_INCLUDED
+#define CUDA_H_INCLUDED
----------------
Contents from D95104, with function pointer replaced with prototype.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95155/new/

https://reviews.llvm.org/D95155