[Openmp-commits] [PATCH] D95062: [libomptarget][devicertl][nfc] Simplify target_atomic abstraction

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

In D95062#2510574 <https://reviews.llvm.org/D95062#2510574>, @JonChesterfield wrote:

> In D95062#2510535 <https://reviews.llvm.org/D95062#2510535>, @jdoerfert wrote:
>
>> LG, can you replace it with clang or OpenMP atomics next?
>
> Yep, expect so. OpenMP probably expects the variables to have atomic types, C++-style, and they're presently a mix of unadorned and volatile.

No, OpenMP does not. In fact, I am unsure if it would work if they were.

> I'll see if I can swap them out for clang intrinsics in the first instance. Moving to atomic types will allow device scoped atomics. If we're feeling brave, could also move to a faster memory order than seq_cst.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95062/new/

https://reviews.llvm.org/D95062