[Openmp-commits] [PATCH] D95048: [libomptarget][devicertl] Wrap source in declare target pragmas

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_locks.hip:30
 DEVICE int __kmpc_impl_test_lock(omp_lock_t *lock) { warn(); }
+#pragma omp end declare target
----------------
tianshilei1992 wrote:
> One nit. There is a blank line between `declare target` and the include, so I’d also insert a blank line between the last line of code and the `end declare target`.
Sure, may as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95048/new/

https://reviews.llvm.org/D95048