[Openmp-commits] [PATCH] D77609: [OpenMP] Added the support for hidden helper task in RTL

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 planned changes to this revision.
tianshilei1992 added a comment.

In D77609#2504139 <https://reviews.llvm.org/D77609#2504139>, @mstorsjo wrote:

> This broke building OpenMP for windows; all the new helper functions, like `__kmp_hidden_helper_threads_initz_wait`, that are added in z_Linux_util.cpp would need to be added similarly to z_Windows_NT_util.cpp. What do you propose doing - revert the patch for now until that's in place?

Thanks for the report. We had a macro controlling whether the feature is enabled before. On Windows the macro is not defined so that corresponding parts in common files will not be built on Windows. Later we decided to remove the macro and turn the feature ON by default but I forgot to add the logic in Windows files, and I didn’t have Windows machines then.......

I’ve reverted the change and will fix the issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77609/new/

https://reviews.llvm.org/D77609