[Openmp-commits] [PATCH] D93169: [OpenMP] Added the support for cache line size 256 for A64FX

Sun Jan 17 16:20:08 PST 2021

chandlerc added a comment.

In D93169#2503960 <https://reviews.llvm.org/D93169#2503960>, @chandlerc wrote:

> In D93169#2503947 <https://reviews.llvm.org/D93169#2503947>, @tianshilei1992 wrote:
>
>> In D93169#2503946 <https://reviews.llvm.org/D93169#2503946>, @chandlerc wrote:
>>
>>> I'm going to revert this as it breaks CMake on systems which do not have `/proc/cpuinfo` such as macOS.
>>>
>>> This may be a bit hard to see because the code isn't reached unless the architecture is `aarch64`, but on an ARM macOS system that path hits. It would also hit on other BSDs or other OSes running on AArch64 but without `/proc/cpuinfo`.
>>>
>>> For your reference, here is the error message from CMake for me:
>>>
>>>   CMake Error at /Users/chandlerc/src/llvm/llvm-project/openmp/runtime/cmake/LibompGetArchitecture.cmake:74 (file):
>>>     file failed to open for reading (No such file or directory):
>>>   
>>>       /proc/cpuinfo
>>>   Call Stack (most recent call first):
>>>     /Users/chandlerc/src/llvm/llvm-project/openmp/runtime/CMakeLists.txt:73 (libomp_is_aarch64_a64fx)
>>
>> Will fix it right away.
>
> I didn't think my CMake fu was up to it, but I think I have a fix, WDYT: https://reviews.llvm.org/D94889

And thanks to the speedy review, landed fix in: https://github.com/llvm/llvm-project/commit/f855751c1284c82c1c46b98f6d1b3ca2021d6cb9

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93169/new/

https://reviews.llvm.org/D93169