[Openmp-commits] [PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 marked an inline comment as done.
tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:73
+// Forward declaration
+extern uint32_t __ffs(uint32_t);
+extern uint32_t __popc(uint32_t);
----------------
JonChesterfield wrote:
> We can (and should) call clang's ffs/popcount instead of these
We could also directly include `__clang_openmp_device_functions.h` if they're already covered by the header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94745/new/

https://reviews.llvm.org/D94745