[Openmp-commits] [PATCH] D94541: [OpenMP] Fixed the link error that cannot find static data member

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 12 13:48:42 PST 2021


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG68ff52ffead2: [OpenMP] Fixed the link error that cannot find static data member (authored by tianshilei1992).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94541/new/

https://reviews.llvm.org/D94541

Files:
  openmp/libomptarget/plugins/common/MemoryManager/MemoryManager.h


Index: openmp/libomptarget/plugins/common/MemoryManager/MemoryManager.h
===================================================================
--- openmp/libomptarget/plugins/common/MemoryManager/MemoryManager.h
+++ openmp/libomptarget/plugins/common/MemoryManager/MemoryManager.h
@@ -338,4 +338,9 @@
   }
 };
 
+// GCC still cannot handle the static data member like Clang so we still need
+// this part.
+constexpr const size_t MemoryManagerTy::BucketSize[];
+constexpr const int MemoryManagerTy::NumBuckets;
+
 #endif // LLVM_OPENMP_LIBOMPTARGET_PLUGINS_COMMON_MEMORYMANAGER_MEMORYMANAGER_H


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94541.316227.patch
Type: text/x-patch
Size: 591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210112/d8778b8e/attachment.bin>


More information about the Openmp-commits mailing list