[Openmp-commits] [PATCH] D94528: [libomptarget][amdgpu][nfc] Fix build on centos

Tony Tye via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 12 11:30:17 PST 2021


t-tye added inline comments.


================
Comment at: openmp/libomptarget/plugins/amdgpu/src/rtl.cpp:641
 bool elf_machine_id_is_amdgcn(__tgt_device_image *image) {
-  const uint16_t amdgcnMachineID = EM_AMDGPU;
+  const uint16_t amdgcnMachineID = 224; // EM_AMDGPU may not be in system elf.h
   int32_t r = elf_check_machine(image, amdgcnMachineID);
----------------
What ELF header file is being used? Should it be using the LLVM provide one which does have the definition? Or is this file part of a component that does not want a dependency on LLVM headers even though it is present in the LLVM code base?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94528/new/

https://reviews.llvm.org/D94528



More information about the Openmp-commits mailing list