[Openmp-commits] [PATCH] D94443: [OpenMP] Take elf_common.c as a interface library

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Jan 11 12:42:12 PST 2021


tianshilei1992 added a comment.

In D94443#2491165 <https://reviews.llvm.org/D94443#2491165>, @JonChesterfield wrote:

> Yep, that looks like it'll work. The included source is a good thing to get rid of. Did you consider a header only library instead? There isn't much code in elf_common and we already know the headers work in the various rtl.cpp

Actually an interface library is the way in CMake to implement a header only library. :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94443/new/

https://reviews.llvm.org/D94443



More information about the Openmp-commits mailing list