[Openmp-commits] [PATCH] D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Jan 10 13:42:04 PST 2021


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

In D93738#2484324 <https://reviews.llvm.org/D93738#2484324>, @protze.joachim wrote:

> LGTM, and should work for the runtime tests.
>
> I could not figure out, why `clang-resource-headers` was there in the first place. As I understand `clang-resource-headers`, it's just an install target? 
> Also, the relevant files behind this target seem to be target-specific wrappers of headers like `math.h` and  `new`. They might be relevant for some libomptarget tests? But, grep didn't show any use of math headers in libomptarget tests.

If they are needed, we'll figure it out. So far it looks they are not. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93738/new/

https://reviews.llvm.org/D93738



More information about the Openmp-commits mailing list