[Openmp-commits] [PATCH] D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Jan 10 13:11:40 PST 2021


JonChesterfield added a comment.

The complexity of this approach is very high relative to instantiating MemoryManagerTy in the cuda plugin, and optionally in any others that want to use it.



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:293
 
+  // Struct to store call back inforation that will be used the plugin is
+  // destructed.
----------------
It looks like this stuff needs to be implemented in every plugin, since they all use the memory manager at present


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94256/new/

https://reviews.llvm.org/D94256



More information about the Openmp-commits mailing list