[Openmp-commits] [PATCH] D93169: [OpenMP] Added the support for cache line size 256 for A64FX

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 7 23:30:42 PST 2021


Hahnfeld added inline comments.


================
Comment at: openmp/runtime/cmake/LibompGetArchitecture.cmake:78-81
+  set(is_aarch64_a64fx "0")
+  if (cpu_architecture AND cpu_implementer)
+    set(is_aarch64_a64fx "1")
+  endif()
----------------
Can you use `TRUE` and `FALSE` here? This also avoids the overly generic `MATCHES "1"` at call site.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93169/new/

https://reviews.llvm.org/D93169



More information about the Openmp-commits mailing list