[Openmp-commits] [PATCH] D94256: [OpenMP] Fixed the issue that memory manager calls plugin interface to release buffered memory even after the plugin has been destroyed

Thu Jan 7 20:52:28 PST 2021

JonChesterfield added a comment.

In D94256#2485965 <https://reviews.llvm.org/D94256#2485965>, @tianshilei1992 wrote:

> In D94256#2485287 <https://reviews.llvm.org/D94256#2485287>, @JonChesterfield wrote:
>
>> I suppose this is better, though it seems backwards to me. Plus we still leak memory with this design.
>
> The memory will be eventually released by the driver if the process is terminated, right?

Maybe. Probably platform-specific. I definitely have to power cycle GPUs to get them working again occasionally so the kernel doesn't (always?) leave the stack in a just-booted state after process exit.

Leaking memory by design thwarts using memory tracking tools to find accidental leaks. In this case, it's indicative that we've failed to establish static lifetimes for the components. Too much global state.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94256/new/

https://reviews.llvm.org/D94256