[Openmp-commits] [PATCH] D94095: [libomptarget] Allow calls to omp_target_memcpy with 0 size.

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 5 09:27:48 PST 2021


JonChesterfield added a comment.

Semantic change is good.

Did you consider putting the equal zero test within the existing <= condition? Length zero should be infrequent (and when statically detected we should elide the call), so we can have one fewer conditional branch on the hot path. Probably in the noise though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94095/new/

https://reviews.llvm.org/D94095



More information about the Openmp-commits mailing list