[Openmp-commits] [PATCH] D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sun Jan 3 18:05:12 PST 2021


tianshilei1992 added a comment.

The reason the two dependent targets are missing is that `clang` is not imported to CMake in the second run. There is a `find_package(LLVM)` but no `find_package(Clang)`. So if I add that missing package, `clang` will be resolved. However, `clang-resource-headers` is still missing because in the CMake module of Clang, `clang-resource-headers` is not exported. IMO, `clang-resource-headers` is not important here at all because once we have `clang`, `clang` can always find those headers as they're in the hard-coded path, so it's kind of redundant to have both `clang` and `clang-resource-headers` here. Like I said before, even `clang` is not needed because we already set the C/C++ compiler to `clang`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93738/new/

https://reviews.llvm.org/D93738



More information about the Openmp-commits mailing list