[Openmp-commits] [PATCH] D93738: [OpenMP] Not set OPENMP_STANDALONE_BUILD=ON when building OpenMP along with LLVM

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

If I build llvm-project using an old compiler, the dependencies are necessary in order to have clang built before running the OpenMP tests. Dropping the dependencies might cause issues in parallel builds, but will make the check-openmp targets incomplete.
What is the problem in having the dependency there?



================
Comment at: llvm/runtimes/CMakeLists.txt:129
 
   foreach(entry ${runtimes})
     get_filename_component(projName ${entry} NAME)
----------------
Are you sure that openmp is in `${runtimes}`?


================
Comment at: openmp/cmake/OpenMPTesting.cmake:188-189
   else()
+    # Since we're building along with LLVM, clang and clang-resource-headers are
+    # guaranteed so we don't need them in DEPENDS, which can cause issues.
     if (ARG_EXCLUDE_FROM_CHECK_ALL)
----------------
The dependency allows to run `ninja check-libomp` in a newly configured BUILD-dir. 
When you drop this dependency, clang will not be built and the testing will fail. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93738/new/

https://reviews.llvm.org/D93738