[Openmp-commits] [PATCH] D97088: [OpenMP][NFC] clang-format the whole openmp project

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/interface.h:182
 typedef struct ident {
   kmp_int32 reserved_1; /**<  might be used in Fortran; see above  */
+  kmp_int32 flags;      /**<  also f.flags; KMP_IDENT_xxx flags; KMP_IDENT_KMPC
----------------
The latest version of `clang-format` can surprisingly handle this type of comments so well!


================
Comment at: openmp/runtime/doc/doxygen/libomp_interface.h:1
-// This file does not contain any code; it just contains additional text and formatting
-// for doxygen.
-
+// This file does not contain any code; it just contains additional text and
+// formatting for doxygen.
----------------
This file should be filtered out.


================
Comment at: openmp/runtime/src/thirdparty/ittnotify/disable_warnings.h:15
+#pragma warning(disable : 593) /* parameter "XXXX" was set but never used */
+#pragma warning(disable : 344) /* typedef name has already been declared (with \
+                                  same type) */
----------------
The tailing `\` is unnecessary. Probably because `clang-format` takes it part of the pragma.


================
Comment at: openmp/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp:1045
 #pragma warning(push)
-#pragma warning(disable: 4054) /* warning C4054: 'type cast' : from function pointer 'XXX' to data pointer 'void *' */
-#pragma warning(disable: 4055) /* warning C4055: 'type cast' : from data pointer 'void *' to function pointer 'XXX' */
+#pragma warning(disable : 4054) /* warning C4054: 'type cast' : from function  \
+                                   pointer 'XXX' to data pointer 'void *' */
----------------
Here as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97088/new/

https://reviews.llvm.org/D97088