[Openmp-commits] [PATCH] D96998: [OPENMP][AMDGCN] Improvements to print_kernel_trace (bit mask)

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Not Johannes, but probably yes. Wonder if we're missing the license header on other files in this plugin.

The ` int print_kernel_trace` is a wide contract - it suggests it might be toggled from anywhere. Which it isn't. We should change to something more like the other debug/env wrapper and use a function call to access. Independent of this review - just reminded of it by seeing the raw int declaration.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96998/new/

https://reviews.llvm.org/D96998