[Openmp-commits] [PATCH] D97012: [OpenMP] Fix nvptx CUDA_VERSION conversion

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Feb 18 17:38:30 PST 2021


tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LGTM with one nit. Thanks for the fix!



================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:179
+    else()
+      message(FATAL_ERROR "Unrecognized CUDA version format: ${cuda_version}")
+    endif()
----------------
You can use `libomptarget_error_say("Unrecognized CUDA version format: ${cuda_version}")` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97012/new/

https://reviews.llvm.org/D97012



More information about the Openmp-commits mailing list