[Openmp-commits] [PATCH] D96999: [OpenMP] Fix always, from and delete for data absent at exit

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added a subscriber: ABataev.
jdenny added a comment.

In D96999#2573081 <https://reviews.llvm.org/D96999#2573081>, @grokos wrote:

> Is this the missing behavior from D83061 <https://reviews.llvm.org/D83061>?

You mean the map clause reordering stuff?  No, as far as I know, it has no effect on that.  I believe @ABataev was working on something along those lines, but unfortunately I lost track.

> Looks good, thanks!

Thanks!



================
Comment at: openmp/libomptarget/src/omptarget.cpp:579-580
+    // list item is ignored."
+    if (!TgtPtrBegin)
+      continue;
+
----------------
RaviNarayanaswamy wrote:
> Can you print a message under debug pointer does not exist.
I'm happy to add an additional message, but what do you want beyond the `DP` invocations in the preceding `if` and `else`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96999/new/

https://reviews.llvm.org/D96999