[Openmp-commits] [PATCH] D95816: [OpenMP] libomp: minor changes to improve library performance

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added inline comments.


================
Comment at: openmp/runtime/src/kmp_itt.h:103
+      __kmp_itt_taskwait_finished(gtid, obj);
 
 // --- Task reporting ---
----------------
jdoerfert wrote:
> Is there a reason to prefer macros over inline linkage functions?
Using functions would need to make UNLIKELY macro visible here. The macro is defined in ompt-internal.h which does not look elegant to be included here.  Duplicating the macro definition is also not a good solution. Moving the definition to some "neutral" place needs efforts, might be implemented separately if needed.

Hopefully ITT will eventually be removed from the code as non-standard profiling technique.  But this may take (many) years until OMPT gets all the features ITT has, and then profilers (like Intel VTune) can shift from ITT to OMPT as it is a standard technique.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95816/new/

https://reviews.llvm.org/D95816