[Openmp-commits] [PATCH] D96444: [OpenMP][NFC] Use `AsyncInfo` as the variable name for a `__tgt_async_info`

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Feb 10 15:06:32 PST 2021


jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:1203
     int32_t thread_limit, uint64_t loop_tripcount,
-    __tgt_async_info *async_info_ptr) {
+    __tgt_async_info *AsyncInfo) {
   assert(DeviceRTL.isValidDeviceId(device_id) && "device_id is invalid");
----------------
tianshilei1992 wrote:
> These functions are C interfaces. Do we want to use C style here?
Because `sed` apparently doesn't distinguish. I try to manually go through and adjust before committing.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96444/new/

https://reviews.llvm.org/D96444



More information about the Openmp-commits mailing list