[Openmp-commits] [PATCH] D96438: [OpenMP] Move synchronization into `__tgt_async_info`

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/libomptarget/include/omptarget.h:136
+/// The libomptarget wrapper around a __tgt_async_info object directly
+/// associated with a libomptarget layer device. RAII semantics to avoid
+/// mistakes.
----------------
Not sure the wrapper has a bonus to fix issues mentioned in D96431.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1144
         Ret = Device.submitData(TgtPtrBegin, &PointerTgtPtrBegin,
-                                sizeof(void *), AsyncInfo);
+                                sizeof(void *), *AsyncInfo);
         if (Ret != OFFLOAD_SUCCESS) {
----------------
The last argument of `DeviceTy::submitData` is `__tgt_async_info *`. I'm thinking we can pass `AsyncInfoTy &` here and all conversion is done in `DeviceTy` such that all interfaces in `libomptarget` use same thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96438/new/

https://reviews.llvm.org/D96438