[Openmp-commits] [PATCH] D96428: [OpenMP][NFC] Clang format libomptarget code (src & include)

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/rtl.cpp:13
 
+#include "rtl.h"
 #include "device.h"
----------------
grokos wrote:
> JonChesterfield wrote:
> > Hopefully header order is not significant. I think there was something where one header required a definition of a macro before it was included, but that may have been fixed in the changes to debug print.
> You are referring to `plugins/common/elf_common/elf_common.h`. This header file uses macro `DP()` without including `Debug.h`, so `Debug.h` must have been included in the plugin's source file before `elf_common.h`. This requirement still exists, so we must be careful if we clang-format the plugins.
I guess it will break if we do it wrong ;)

A new line ensures there is no reordering by clang-format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96428/new/

https://reviews.llvm.org/D96428