[Openmp-commits] [PATCH] D96379: [OpenMP] Unify omptarget API and usage wrt. `__tgt_async_info`
Johannes Doerfert via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Feb 10 10:04:24 PST 2021
jdoerfert added a comment.
In D96379#2553389 <https://reviews.llvm.org/D96379#2553389>, @JonChesterfield wrote:
> Interesting.
>
> A big cleanup would be for the async object passed to the plugins to always be non-null. Add an API to construct an async object, let synchronise act as the destructor. Then every _async call is passed a valid, not null thing to work with, and we remove N points of if-passed-null-try-to-construct.
>
> Async would then look more like start transaction, append entries, finalise transaction.
Yes, but layer by layer. For now, we make it a required object on the omptarget layer and then we go down.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96379/new/
https://reviews.llvm.org/D96379
More information about the Openmp-commits
mailing list