[Openmp-commits] [PATCH] D96429: [OpenMP][NFC] Pass a DeviceTy, not the device number to `target`

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:18
 
+#include <bits/stdint-intn.h>
 #include <cassert>
----------------
JonChesterfield wrote:
> tianshilei1992 wrote:
> > A bit of noise here
> ^looks like an overenthusiastic editor. stdint.h?
already gone


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1245
            int32_t ThreadLimit, int IsTeamConstruct) {
-  DeviceTy &Device = PM->Devices[DeviceId];
+  int32_t DeviceId = Device.DeviceID;
 
----------------
JonChesterfield wrote:
> Changes from int64 to int32 here. Either is presumably fine, probably good to use the same width across the library.
int32 is the type of the `DeviceID` member ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96429/new/

https://reviews.llvm.org/D96429