[Openmp-commits] [PATCH] D96429: [OpenMP][NFC] Pass a DeviceTy, not the device number to `target`

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 accepted this revision.
tianshilei1992 added a comment.
This revision is now accepted and ready to land.

LG. Some nits.



================
Comment at: openmp/libomptarget/src/omptarget.cpp:18
 
+#include <bits/stdint-intn.h>
 #include <cassert>
----------------
A bit of noise here


================
Comment at: openmp/libomptarget/src/private.h:16
 
+#include "device.h"
 #include <Debug.h>
----------------
We could probably use forward declaration to avoid an include.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96429/new/

https://reviews.llvm.org/D96429