[Openmp-commits] [PATCH] D95300: [OpenMP][deviceRTLs] Separate declaration of target dependent functions from `target_impl.h`

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Feb 8 12:08:56 PST 2021


JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip:192
 
+DEVICE void __kmpc_impl_unpack(uint64_t val, uint32_t &lo, uint32_t &hi) {
+  lo = (uint32_t)(val & UINT64_C(0x00000000FFFFFFFF));
----------------
I missed the language linkage change from c++ to c on these, fixed on main.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95300/new/

https://reviews.llvm.org/D95300



More information about the Openmp-commits mailing list