[Openmp-commits] [PATCH] D95585: [OpenMP] Disabled profiling in `libomp` by default to unblock link errors

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

In D95585#2541372 <https://reviews.llvm.org/D95585#2541372>, @mstorsjo wrote:

> The cherrypick of this commit to the 12.x branch broke building of openmp there, with errors like these:
>
>   CMake Error at CMakeLists.txt:93 (add_subdirectory):
>     The binary directory
>   
>       /build/llvm-project/openmp/build-i686/runtime
>   
>     is already used to build a source directory.  It cannot be used to build
>     source directory
>   
>       /build/llvm-project/openmp/runtime
>   
>     Specify a unique binary directory name.
>
> That's because on the main branch, D95398 <https://reviews.llvm.org/D95398> moved the `add_subdirectory(runtime)`, but that bit isn't cherrypicked to the release branch, and the cherry pick conflict seems to have been resolved incorrectly.

Thanks for the report. Now it is fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95585/new/

https://reviews.llvm.org/D95585