[Openmp-commits] [PATCH] D95986: [OpenMP][deviceRTLs] Drop `assert` in common parts of `deviceRTLs`

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield added a comment.

Yep, like this.

Ptx documents an intrinsic/builtin/syscall thing for assert that we could use instead of trap. Involves creating a call to __assertfail, takes five arguments one of which is sizeof(char). This is much simpler and serves the same purpose though.

Could you delete the assert impl from amdgpu at the same time?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95986/new/

https://reviews.llvm.org/D95986