[Openmp-commits] [PATCH] D95820: [OpenMP] Add bounds to num_teams clause (OpenMP 5.1)

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/runtime/src/kmp.h:3367
+extern void __kmp_push_num_teams_5(ident_t *loc, int gtid, int num_teams_lb,
+                                   int num_teams_ub, int num_threads);
 
----------------
Given the version name, should we go with `_51`?


================
Comment at: openmp/runtime/src/kmp_runtime.cpp:7537
+      num_teams = __kmp_teams_max_nth;
+    }
+  } else if (num_teams_lb == num_teams_ub) { // required exact number of teams
----------------
IIRC, this is not correct anymore in 5.1. We cannot cap the number of teams. We need to implement a loop if the number of physical teams is smaller than the number requested teams to basically emulate as many as have been requested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95820/new/

https://reviews.llvm.org/D95820