[Openmp-commits] [PATCH] D95816: [OpenMP] libomp: minor changes to improve library performance

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added a comment.

UNLIKELY and assert seem ok, the third change not so much.



================
Comment at: openmp/runtime/src/kmp_tasking.cpp:1926
+    }
+#endif /* USE_ITT_NOTIFY */
 #endif /* USE_ITT_BUILD */
----------------
This seems very unfortunate TBH. Now we duplicate the function body 3 times for some minor speedup somewhere? That is a slippery slope. What about a header implementation? Building the runtime with LTO?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95816/new/

https://reviews.llvm.org/D95816