[Openmp-commits] [PATCH] D95798: [OpenMP] Fixed an issue that taskwait doesn't work on detachable task

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Feb 1 10:03:41 PST 2021

tianshilei1992 created this revision.
tianshilei1992 added reviewers: jdoerfert, AndreyChurbanov.
Herald added subscribers: guansong, yaxunl.
tianshilei1992 requested review of this revision.
Herald added subscribers: openmp-commits, sstefan1.
Herald added a project: OpenMP.

D77609 <https://reviews.llvm.org/D77609> mistakenly changed the bebavior of task waiting on detachable task
that a detachable task is not waited. This patch fixed it. Thank Raúl for the report.

  rG LLVM Github Monorepo



Index: openmp/runtime/src/kmp_tasking.cpp
--- openmp/runtime/src/kmp_tasking.cpp
+++ openmp/runtime/src/kmp_tasking.cpp
@@ -1271,7 +1271,7 @@
-    if (flags->proxy == TASK_PROXY &&
+    if ((flags->proxy == TASK_PROXY || flags->detachable == TASK_DETACHABLE) &&
         task_team->tt.tt_found_proxy_tasks == FALSE)
       TCW_4(task_team->tt.tt_found_proxy_tasks, TRUE);
     if (flags->hidden_helper &&

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95798.320511.patch
Type: text/x-patch
Size: 491 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20210201/251e1ad9/attachment.bin>

More information about the Openmp-commits mailing list