[Openmp-commits] [PATCH] D95786: [OpenMP] Fix seg fault in libomptarget when using Info with multiple threads

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Feb 1 08:49:47 PST 2021


jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/src/private.h:112
        "Target Ptr", "Size (B)", "RefCount", "Declaration");
+  Device.DataMapMtx.lock();
   for (const auto &HostTargetMap : Device.HostDataToTargetMap) {
----------------
JonChesterfield wrote:
> Is this stuff built with exceptions disabled? Used to seeing unlock() called from destructors.
This is the same thing that the Device type uses to protect the data mapping when it adds or removes something so I'm assuming it's compatible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95786/new/

https://reviews.llvm.org/D95786



More information about the Openmp-commits mailing list